pierrejeambrun commented on PR #29545:
URL: https://github.com/apache/airflow/pull/29545#issuecomment-1430458434

   I think it's ok like this. Attribute are taken from `get_attr_renderer` and 
it seems that all of them are 'string'. Skipping falsy values looks good.
   
   (I was concerned that some attributes could be of different types, like 
boolean or int for instance, but it doesn't seem like so)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to