Aakcht commented on PR #29347:
URL: https://github.com/apache/airflow/pull/29347#issuecomment-1431948430
@ferruzzi I'd say that this PR is about the timeout for waiting for command
reply. For example, consider the command
```bash
sleep 10
```
(as actually used in the tests for this PR). If `cmd_timeout`>10, the
command should execute successfully, if `cmd_timeout`<10 it'll fail.
<br />
<br />
But this PR doesn't actually add this `cmd_timeout` and instead fixes a bit
different problem. The `cmd_timeout` was already added before (in #27184), but
only for SSH hook/operator. In that previous PR the `cmd_timeout` value was set
by default to 10 seconds (instead of "no timeout" which was the previous
behavior).
So this PR fixes two issues that appeared after #27184:
1) It adds possibility to configure `cmd_timeout` not only in SSH hook/SSH
operator, but also in SSH connection(so now you don't have to modify your DAG
code to set it).
2) It adds possibility to set it to `''` in SSH connection which means "no
timeout" and restore the behavior that was in place before #27184.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
