josh-fell commented on code in PR #29548:
URL: https://github.com/apache/airflow/pull/29548#discussion_r1107926537
##########
tests/providers/amazon/aws/operators/test_ec2.py:
##########
@@ -20,23 +20,83 @@
from moto import mock_ec2
from airflow.providers.amazon.aws.hooks.ec2 import EC2Hook
-from airflow.providers.amazon.aws.operators.ec2 import
EC2StartInstanceOperator, EC2StopInstanceOperator
+from airflow.providers.amazon.aws.operators.ec2 import (
+ EC2CreateInstanceOperator,
+ EC2StartInstanceOperator,
+ EC2StopInstanceOperator,
+ EC2TerminateInstanceOperator,
+)
class BaseEc2TestClass:
@classmethod
- def _create_instance(cls, hook: EC2Hook):
- """Create Instance and return instance id."""
+ def _get_image_id(cls, hook):
+ """Get a valid image id to create an instance."""
conn = hook.get_conn()
try:
ec2_client = conn.meta.client
except AttributeError:
ec2_client = conn
-
- # We need existed AMI Image ID otherwise `moto` will raise
DeprecationWarning.
+
+ # We need an existing AMI Image ID otherwise `moto` will raise
DeprecationWarning.
images = ec2_client.describe_images()["Images"]
- response = ec2_client.run_instances(MaxCount=1, MinCount=1,
ImageId=images[0]["ImageId"])
- return response["Instances"][0]["InstanceId"]
+ return images[0]["ImageId"]
+
+class TestEC2CreateInstanceOperator(BaseEc2TestClass):
Review Comment:
Might be wise to add a test for creating multiple instances too. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
