potiuk commented on code in PR #28850: URL: https://github.com/apache/airflow/pull/28850#discussion_r1108517079
########## airflow/providers/amazon/provider.yaml: ########## @@ -52,6 +52,7 @@ dependencies: - apache-airflow>=2.3.0 - apache-airflow-providers-common-sql>=1.3.1 - boto3>=1.24.0 + - aiobotocore>=2.1.1 Review Comment: > 1. AFAIK in CI image only core providers dependencies installed (i guess we have some workaround). That mean we have an error in async Amazon providers tests because there is no aiobotocore Yes. It is quite a bummer that aiobotocore limits botocore that much. Indeed if aiobotocore will be additional extra and will be missing in the image. We could add it, but as @Taragolis mentions, it would limit our botocore upgrades that happen regularly. A solution to that might be: 1) add exclusion in the tests when iobotocore is installed 2) implement an extra job in CI that installs iobotocore and then runs only the iobotocore tests. Should be easy to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
