ashb commented on issue #5584: [AIRFLOW-4950] Simplify string format URL: https://github.com/apache/airflow/pull/5584#issuecomment-511154360 We still need to support Py 3.5 for a while yet, and I'm not in favour of Yet Another Style Checker, and I honestly couldn't care which style of string formatters people use in PRs, my concern here is 1) the current form works and isn't deprecated, it is valid Python 3.8 code. and 2) around git blame/history. To me the explicit numbers are clearer - I prefer the current version of these two: ```diff "Error occurred when calling the grpc service: {0}, method: {1} \ status code: {2}, error details: {3}" "Error occurred when calling the grpc service: {}, method: {} \ status code: {}, error details: {}" ``` (that is admittedly the longest one in the diff) And just so you are aware: if we merge this change it makes a 1.10.5 almost impossible as now there are 62 more files that won't work on Py2. (`super()` was so far the only other major py2 issue and that one is easy enough to catch. This is much trickier.)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
