uranusjr commented on PR #29569: URL: https://github.com/apache/airflow/pull/29569#issuecomment-1434273684
I tried a few approaches. Simply calling `job.scheduler` in `scheduler_command` feels wrong to me (although it does the right thing) since it leaks the fact that the attribute is actually a cached property instantiating the default executor. But putting the validation in ExecutionLoader is actually not optimal since that makes the logic runs every time we instantiate an executor (e.g. for backfill). Right now I’m moving the validation logic to `conf` as a free function and make it cached so it’s called exactly once. We’ll still call it in ExecutorLoader (to make sure all loader calls return a valid executor class), but also call it eagerly in `scheduler_command`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
