Taragolis commented on code in PR #29452:
URL: https://github.com/apache/airflow/pull/29452#discussion_r1109871569
##########
airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py:
##########
@@ -135,7 +156,7 @@ def execute(self, context: Context) -> None:
raise e
finally:
if err is None:
- _upload_file_to_s3(f, self.s3_bucket_name,
self.s3_key_prefix, self.aws_conn_id)
+ _upload_file_to_s3(f, self.s3_bucket_name,
self.s3_key_prefix, str(self.dest_aws_conn_id))
Review Comment:
Ohhh, You could change `_upload_file_to_s3` signature, no problem here at
all this is private function (so you could do whatever you wanted and
required), which for some reason initially in Airflow 1.x implemented outside
of the Operator, and signature `str | None` expected for S3Hook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
