Taragolis commented on code in PR #29394:
URL: https://github.com/apache/airflow/pull/29394#discussion_r1111113802
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -1252,7 +1263,10 @@ class BigQueryCreateEmptyTableOperator(BaseOperator):
If set as a sequence, the identities from the list must grant
Service Account Token Creator IAM role to the directly preceding
identity, with first
account from the list granting this role to the originating account
(templated).
- :param exists_ok: If ``True``, ignore "already exists" errors when
creating the table.
+ :param exists_ok: Deprecated - use `if_exists="ignore"` instead.
+ :param if_exists: What should Airflow do if the table exists. If set to
`log`, the TI will be passed to
+ success and an error message will be logged. Set to `ignore` to ignore
the error, set to `fail` to
+ fail the TI, and set to `skip` to skip it.
Review Comment:
Small nit, I think it is a good idea move deprecated parameters into the
bottom of arguments lists and because operator only supports keyword arguments,
this is not break any pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
