hussein-awala commented on code in PR #29270:
URL: https://github.com/apache/airflow/pull/29270#discussion_r1111335700
##########
chart/templates/logs-persistent-volume-claim.yaml:
##########
@@ -29,6 +29,10 @@ metadata:
{{- with .Values.labels }}
{{- toYaml . | nindent 4 }}
{{- end }}
+ annotations:
+ {{- if .Values.logs.persistence.annotations}}
+ {{- toYaml .Values.logs.persistence.annotations | nindent 4 }}
+ {{- end }}
Review Comment:
If `.Values.logs.persistence.annotations` is not provided or equals to {} or
null, the manifest will contains an empty `annotations` block which brake the
helm upgrade operation, instead you can use `with` function to conditionally
add the annotations key:
```suggestion
{{- with .Values.logs.persistence.annotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
