Taragolis commented on code in PR #29635:
URL: https://github.com/apache/airflow/pull/29635#discussion_r1112150631
##########
airflow/providers/yandex/hooks/yandex.py:
##########
@@ -122,7 +127,8 @@ def __init__(
self.connection = self.get_connection(self.connection_id)
self.extras = self.connection.extra_dejson
credentials = self._get_credentials()
- self.sdk = yandexcloud.SDK(user_agent=self.provider_user_agent(),
**credentials)
+ endpoint = self._get_field("endpoint", False)
+ self.sdk = yandexcloud.SDK(user_agent=self.provider_user_agent(),
endpoint=endpoint, **credentials)
Review Comment:
But it not missing in our case, we would provide `False` in this case and it
would evaluate to this wrong value
```python
kwargs_no_endpoint = {"foo": "bar"}
print(kwargs_no_endpoint.get("endpoint", "api.cloud.yandex.net"))
kwargs_none_endpoint = {"foo": "bar", "endpoint": None}
print(kwargs_none_endpoint.get("endpoint", "api.cloud.yandex.net"))
kwargs_false_endpoint = {"foo": "bar", "endpoint": False}
print(kwargs_false_endpoint.get("endpoint", "api.cloud.yandex.net"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
