hussein-awala commented on PR #29624:
URL: https://github.com/apache/airflow/pull/29624#issuecomment-1437300580

   @amoghrajesh or @potiuk can you please update the description and link the 
PR to the issue?
   
   I think we can add a new value `k8s_pod_template` and use it when the 
executor is `CeleryKubernetesExecutor`:
   - if the executor is `CeleryExecutor`: load conf from `.Values.workers`
   - if the executor is `CeleryKubernetesExecutor`: load celery worker conf 
from `.Values.workers` and pod template conf from `.Values.k8s_pod_template` if 
it exists, and if not we load them from `.Values.workers` or `.Values` as we do 
for now
   - if the executor is `KubernetesExecutor`: we load pod template conf from 
`.Values.k8s_pod_template` if exists, and if not we load them from 
`.Values.workers`  or `.Values`
   
   I believe some of the `CeleryKubernetesExecutor` users use the same 
configuration for celery and k8s, if we separate the configurations in two 
sections, they will need to duplicate them. With my suggestion, they can keep 
them identical, or override them/some of them in the section k8s_pod_template


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to