potiuk commented on code in PR #29513:
URL: https://github.com/apache/airflow/pull/29513#discussion_r1112952981
##########
airflow/models/taskinstance.py:
##########
@@ -1207,9 +1208,11 @@ def get_dagrun(self, session: Session = NEW_SESSION) ->
DagRun:
return dr
+ @staticmethod
+ @internal_api_call
@provide_session
def check_and_change_state_before_execution(
- self,
+ ti: TaskInstance,
Review Comment:
Just a comment: I am working on a small POC to see the scope of refactoring
that we would have to do to avoid serializing TaskInstance over the internal
API call. Stay tuned. It's not a "few lines" one after the closer look so it
might take a moment before I figure out the extend of modifications needed (I
want to make it as small of a change to airflow internal code as possible to
avoid huge set of changes). I am not sure yet if that will be as simple as I
thought, but .. stay tuned please :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
