potiuk commented on PR #29143:
URL: https://github.com/apache/airflow/pull/29143#issuecomment-1438506435
> We should separate purposes and store code for docs separate from tests,
i.e. in the /docs folder. Since that would be a bigger change, happy to close
this PR for now and use it to demonstrate how that change might work.
I think we agree on that. I am absolutely for separating those two use cases
for users. Users when installing Airflow by default (for production) should not
see those. But I think those `example_dags` (they can be renamed to `doc dags`
or something should also be possible to bring back to be visible in the UI by
simple "opt-in" flag, without manual copying those files to the dags folder of
theirs. This is great value for people who are exploring airlfow and want to
get the grasp of it. Equivakent to "playground" in a number of services that
show how an application works.
I think this is really valuable that the user workflow for such a "playful"
user is:
* `pip install airflow`
* `airflow standalone --load-example-dags`
And be able to run them.
Same for `breeze` and local venv environment, where the contributor would be
able to run those examples without copying them to their DAG folder. Then the
benefit is that you can easily make sure that the dags are still working while
you are making changes to some core classes - and that you won't forget to
copy-back the changed/fixed example dags from your DAG folder when you are done
(because you will be editing them in-place in your sources and commit together
with the rest).
So I have no problems with moving the dags to "docs" section, as long as the
workflows above continue to work.
It basically means that the example dags (or doc dags) will have to be
embedded in airflow code when package is prepared (or taken from docs or
whatever when run from developer's venv/breeze).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
