josh-fell commented on code in PR #29549:
URL: https://github.com/apache/airflow/pull/29549#discussion_r1113079693
##########
airflow/providers/google/cloud/hooks/bigquery.py:
##########
@@ -240,7 +240,7 @@ def get_pandas_df(
query. The DbApiHook method must be overridden because Pandas
doesn't support PEP 249 connections, except for SQLite. See:
- https://github.com/pydata/pandas/blob/master/pandas/io/sql.py#L447
+ https://github.com/pydata/pandas/blob/main/pandas/io/sql.py#L447
Review Comment:
Good point! I updated the links in da85a59f3ba420c4c4ec1abe9fc393840516bb2a
(they were outdated anyway). I think keeping the links there is still helpful.
There is a pandas issue also linked, but reading through that conversation can
be cumbersome even though it is good context for _why_ only SQLite is supported
with DBAPIv2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
