[GitHub] [airflow] eeshugerman edited a comment on issue #5573: [AIRFLOW-4929] Pretty print JSON Variables in UI

Sun, 14 Jul 2019 17:55:40 -0700 

eeshugerman edited a comment on issue #5573: [AIRFLOW-4929] Pretty print JSON 
Variables in UI
URL: https://github.com/apache/airflow/pull/5573#issuecomment-511249000
 
 
   Thanks @ashb! Got it working.
   
   I've fixed the tests and added two more to changes to this PR, both to do 
with the `val` text box on the "Edit Variable" page
   - use a monospaced font (requested here 
https://issues.apache.org/jira/browse/AIRFLOW-310)
   - increase height to fit content, up to a point
   
   Here are screenshots from the master branch:
   
   ### before
   
![before2](https://user-images.githubusercontent.com/25518211/61191300-fb53ed80-a665-11e9-90a0-3aecbef3804e.png)
   
   ### after
   #### long variable
   
![after2](https://user-images.githubusercontent.com/25518211/61191305-06a71900-a666-11e9-80e9-0d3d94854d5b.png)
   #### short variable
   
![after_2_short](https://user-images.githubusercontent.com/25518211/61191352-ae244b80-a666-11e9-9f2f-fed12e2c27ef.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to