ashb commented on code in PR #29723:
URL: https://github.com/apache/airflow/pull/29723#discussion_r1115730839
##########
setup.py:
##########
@@ -193,7 +190,7 @@ def git_version(version_: str) -> str:
if repo.is_dirty():
return f".dev0+{sha}.dirty"
# commit is clean
- return f".release:{version_}+{sha}"
+ return f".release:{sha}"
Review Comment:
This changes format of the git tag, but given this is shown directly beneath
the actual version in the UI it seemed easier to change it this way, rather
than have to have this do the ast eval to get version too.
If anyone thinks otherwise I can change the style back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
