dimberman commented on code in PR #29602: URL: https://github.com/apache/airflow/pull/29602#discussion_r1116186682
########## airflow/config_templates/default_airflow.cfg: ########## @@ -1120,11 +1120,12 @@ catchup_by_default = True ignore_first_depends_on_past_by_default = True # This changes the batch size of queries in the scheduling main loop. +# This should not be greater than ``core.parallelism``. # If this is too high, SQL query performance may be impacted by # complexity of query predicate, and/or excessive locking. # Additionally, you may hit the maximum allowable query length for your db. -# Set this to 0 for no limit (not advised) -max_tis_per_query = 512 +# Setting this to 0 for using the value of ``core.parallelism`` +max_tis_per_query = 16 Review Comment: Since "scheduler.max_tis_per_query should not be greater than core.parallelism ", maybe we should add code in airflow that checks and either fails or emits a warning if a user is not meeting this condition. wherever possible we should push users to keep with best practices. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
