moiseenkov commented on code in PR #29462: URL: https://github.com/apache/airflow/pull/29462#discussion_r1117156672
########## tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service_async.py: ########## @@ -0,0 +1,162 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import json +import sys + +import pytest +from google.auth.exceptions import GoogleAuthError + +from airflow import AirflowException +from airflow.providers.google.cloud.hooks.cloud_storage_transfer_service import ( + CloudDataTransferServiceAsyncHook, +) +from tests.providers.google.cloud.utils.base_gcp_mock import mock_base_gcp_hook_default_project_id + +if sys.version_info < (3, 8): + from asynctest import mock +else: + from unittest import mock + + +TEST_PROJECT_ID = "project-id" + + [email protected] +def hook_async(): + with mock.patch( + "airflow.providers.google.common.hooks.base_google.GoogleBaseAsyncHook.__init__", + new=mock_base_gcp_hook_default_project_id, + ): + yield CloudDataTransferServiceAsyncHook() + + +if sys.version_info < (3, 8): Review Comment: Thanks for noticing. Done. ########## tests/providers/google/cloud/hooks/test_cloud_storage_transfer_service_async.py: ########## @@ -0,0 +1,162 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import json +import sys + +import pytest +from google.auth.exceptions import GoogleAuthError + +from airflow import AirflowException +from airflow.providers.google.cloud.hooks.cloud_storage_transfer_service import ( + CloudDataTransferServiceAsyncHook, +) +from tests.providers.google.cloud.utils.base_gcp_mock import mock_base_gcp_hook_default_project_id + +if sys.version_info < (3, 8): Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
