jedcunningham commented on code in PR #29752:
URL: https://github.com/apache/airflow/pull/29752#discussion_r1117788071
##########
chart/values.schema.json:
##########
@@ -4588,6 +4588,56 @@
"verify-full"
],
"default": "disable"
+ },
+ "livenessProbe": {
+ "description": "LivenessProbe configurations for
``metricsExporterSidecar``",
+ "type": "object",
+ "additionalProperties": false,
+ "properties": {
+ "initialDelaySeconds": {
+ "description": "Metrics Exporter liveness
probe initial delay",
+ "format": "int32",
+ "type": "integer",
+ "default": 10
+ },
+ "periodSeconds": {
+ "description": "Metrics Exporter liveness
probe frequency",
+ "format": "int32",
Review Comment:
Does helm honor these formats? We don't have them for anything else, and the
one instance of it for periodSeconds in the upstream k8s schema has this as
int64.
I'd be inclined to just remove all the formats you are adding here, unless
you are sure helm actually checks them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
