ashb commented on a change in pull request #5585: [AIRFLOW-4951] Use new style
classes
URL: https://github.com/apache/airflow/pull/5585#discussion_r303387547
##########
File path: airflow/_vendor/nvd3/NVD3Chart.py
##########
@@ -36,7 +36,7 @@ def stab(tab=1):
return ' ' * 4 * tab
-class NVD3Chart(object):
+class NVD3Chart:
Review comment:
As a policy/rule I would rather we keep the changes to the _vendor tree as
minimal as possible, that way when we have to update the version of one of the
vendored modules we have as minimal a set of changes as possible to have to
're-port'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
