potiuk commented on code in PR #29760:
URL: https://github.com/apache/airflow/pull/29760#discussion_r1117921522
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -378,22 +378,16 @@ def _render_nested_template_fields(
seen_oids: set,
) -> None:
if id(content) not in seen_oids:
- template_fields: tuple | None = None
-
- if isinstance(content, k8s.V1EnvVar):
- template_fields = ("value", "name")
-
- if isinstance(content, k8s.V1ResourceRequirements):
- template_fields = ("limits", "requests")
-
- if isinstance(content, k8s.V1Volume):
- template_fields = ("name", "persistent_volume_claim")
-
- if isinstance(content, k8s.V1VolumeMount):
- template_fields = ("name",)
-
- if isinstance(content, k8s.V1PersistentVolumeClaimVolumeSource):
- template_fields = ("claim_name",)
+ try:
Review Comment:
I am absolutely not annoyed. It's perfectly normal to get reviewes that are
proposing changes. to proposed PR. I think you take it far too personal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
