pierrejeambrun commented on code in PR #29756:
URL: https://github.com/apache/airflow/pull/29756#discussion_r1117939177
##########
airflow/www/views.py:
##########
@@ -895,6 +895,8 @@ def _iter_parsed_moved_data_table_names():
search=escape(arg_search_query) if arg_search_query else None,
status=arg_status_filter if arg_status_filter else None,
tags=arg_tags_filter if arg_tags_filter else None,
+ sorting_key=arg_sorting_key,
Review Comment:
Check the pattern above for tags, search and status, we should be consistent
(ternary).
##########
airflow/www/utils.py:
##########
@@ -219,7 +219,16 @@ def get_params(**kwargs):
return urlencode({d: v for d, v in kwargs.items() if v is not None}, True)
-def generate_pages(current_page, num_of_pages, search=None, status=None,
tags=None, window=7):
+def generate_pages(
+ current_page,
+ num_of_pages,
+ search=None,
+ status=None,
+ tags=None,
+ window=7,
+ sorting_key=None,
+ sorting_direction=None,
Review Comment:
You need to update the docstring as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
