hussein-awala commented on PR #29772:
URL: https://github.com/apache/airflow/pull/29772#issuecomment-1445356620

   > I would say it would be worth to actually add an option as well to airflow 
configuration (and update default local settins to read the configuration) - it 
will still allow to use the feature without upgrading airflow. But in the 
future it will be as easy as modifying the configuration.
   Also you will be able to copy the local_settings from latest airflow 
version, add configuration (even if you do not upgrade) and new providers and - 
surprisingly - it will also work, because you do not have to have new airflow 
ot read new value from the config. I think for the future - compatibility, this 
could be even described in the docs how to approach it - copy the relevant part 
of settings, add configuration, and then when you migrate in the future, it 
will just work (TM).
   
   Yes, I thought about this, and I had to different options to add the config:
   - Add the config and use it as default value for `delete_local_copy` -> the 
users of Airflow < 2.6.0 should add the config manually because to avoid 
[AirflowConfigException](https://github.com/apache/airflow/blob/main/airflow/configuration.py#L661-L661)
   - Add the config and use it in a try except with a second default value 
`False` defined in each provider -> All the users can configure the 
RemoteTaskHandler using Airflow config or keyword config and it is fully bc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to