bolkedebruin commented on code in PR #29433:
URL: https://github.com/apache/airflow/pull/29433#discussion_r1118424212
##########
airflow/models/dataset.py:
##########
@@ -275,6 +275,8 @@ class DatasetEvent(Base):
source_dag_id = Column(StringID(), nullable=True)
source_run_id = Column(StringID(), nullable=True)
source_map_index = Column(Integer, nullable=True,
server_default=text("-1"))
+ external_service_id = Column(StringID(), nullable=True)
+ external_source = Column(StringID(), nullable=True)
Review Comment:
As per earlier comment from me @uranusjr :
* by whom - external_auth_id or external_service_id -> required
* from where (api, client_ip / remote_addr) - external_source -> required
So they cannot be combined as they contain different information and are
both required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
