jcobb-healx commented on issue #29358: URL: https://github.com/apache/airflow/issues/29358#issuecomment-1446254058
@pierrejeambrun Sorry, I hadn't gotten around to looking at this. Spent a bit of time on this today, and it looks like converting the type hint to `Mapping` isn't right, as the `params` are merged with the default params in an [`update` call](https://github.com/apache/airflow/blob/a5adb87ab4ee537eb37ef31aba755b40f6f29a1e/airflow/models/dag.py#L430), which isn't consistent with `TypedDict` behaviour. Given the earlier `mypy` discussion, it probably makes sense to use `MutableMapping` to allow generic inputs, and let users perform casts, i.e. _not_ accept `TypedDict` objects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
