This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 1e536eb43d `KubernetesPodOperator._render_nested_template_fields`
improved by changing the conditionals for a map (#29760)
1e536eb43d is described below
commit 1e536eb43de4408612bf7bb7d9d2114470c6f43a
Author: José L. Patiño Andrés <[email protected]>
AuthorDate: Tue Feb 28 05:46:37 2023 +0000
`KubernetesPodOperator._render_nested_template_fields` improved by changing
the conditionals for a map (#29760)
* Issue-29759: `KubernetesPodOperator._render_nested_template_fields`
improved by changing the conditionals for a map.
* Issue-29759: Changed mapping approach by exclusive conditional statements.
---
.../cncf/kubernetes/operators/kubernetes_pod.py | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
b/airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
index 1874bf90f5..bf889580bc 100644
--- a/airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
+++ b/airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
@@ -378,22 +378,20 @@ class KubernetesPodOperator(BaseOperator):
seen_oids: set,
) -> None:
if id(content) not in seen_oids:
- template_fields: tuple | None = None
+ template_fields: tuple | None
if isinstance(content, k8s.V1EnvVar):
template_fields = ("value", "name")
-
- if isinstance(content, k8s.V1ResourceRequirements):
+ elif isinstance(content, k8s.V1ResourceRequirements):
template_fields = ("limits", "requests")
-
- if isinstance(content, k8s.V1Volume):
+ elif isinstance(content, k8s.V1Volume):
template_fields = ("name", "persistent_volume_claim")
-
- if isinstance(content, k8s.V1VolumeMount):
+ elif isinstance(content, k8s.V1VolumeMount):
template_fields = ("name",)
-
- if isinstance(content, k8s.V1PersistentVolumeClaimVolumeSource):
+ elif isinstance(content, k8s.V1PersistentVolumeClaimVolumeSource):
template_fields = ("claim_name",)
+ else:
+ template_fields = None
if template_fields:
seen_oids.add(id(content))