[GitHub] [airflow] SamWheating opened a new pull request, #29850: Use hybrid_property for ti.try_number to fix broken filter in in /taskinstance/list View

[via GitHub]

SamWheating opened a new pull request, #29850:
URL: https://github.com/apache/airflow/pull/29850

   closes: https://github.com/apache/airflow/issues/29843
   
   Because the column and column in the DB are both called `try_number`, 
flask-appbuilder ends up trying to build a filter using the `try_number` 
property, which doesn't work.
   
   I think that we _could_ get around this by renaming the property, but that 
would be a huge refactor. Instead, we can just use the `@hybrid_property` 
decorator which will enable different behaviour at the class vs. instance-level.
   
   ([more on sqlalchemy hybrid properties 
here](https://docs.sqlalchemy.org/en/14/orm/extensions/hybrid.html))
   
   Tested this in breeze and can confirm it works:
   <img width="1882" alt="image" 
src="https://user-images.githubusercontent.com/16950874/222294346-4eb9d7f5-1efa-4771-a475-3db9927b42a5.png";>
   
   Will wait for the full tests to run before I claim that this doesn't break 
anything else 🤞 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org