o-nikolas commented on code in PR #29871:
URL: https://github.com/apache/airflow/pull/29871#discussion_r1123582402
##########
airflow/providers/amazon/aws/hooks/ecs.py:
##########
@@ -55,7 +55,24 @@ def should_retry_eni(exception: Exception):
return False
-class EcsClusterStates(str, Enum):
+class _StringCompareEnum(Enum):
Review Comment:
I feel like it is quite trivial to move it to a more generic place (and
still keep it private if you'd prefer that). Seems easy to make the right
choice now rather than having to fix it later. But I wont press any harder,
happy to merge this as is and I can fix it in a follow up PR :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
