TJaniF commented on PR #29842: URL: https://github.com/apache/airflow/pull/29842#issuecomment-1453595438
@uranusjr @eladkal I just realized there is a second thing to consider if the default for `allow_templates_in_result_processor` is set to True. Users who are using the GitHubSensor directly and pass a `result_processor` function directly would either need to turn `allow_templates_in_result_processor` to False or add a `templated_fields` kwarg to their result_processor function. That is probably affecting more users than custom operators and it seems like it could be potentially confusing. I have an idea for a solution that would not break any current direct use of the GithubSensor while making the GitHubTagSensor `tag_name` parameter templateable by default: Having two separate params for the result processor function, one to use when using the sensor directly (the current one `result_processor`, when there will be no templated inputs to that function and a new one `templated_processor` to use in operators inheriting from the GithubSensor. I think this change would not be breaking anything, at least what I can think of. I pushed that version now to compare, let me know which version you think works better. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
