potiuk commented on PR #29766:
URL: https://github.com/apache/airflow/pull/29766#issuecomment-1454747547
> If I'm not mistaken, RATELIMIT_ENABLED will broadly enable rate limit
since it can be added on ModelRestApi classes and AUTH_RATE_LIMITED will need
RATELIMIT_ENABLED and add it to the auth views
Yep. I linked those two in Airflow configuration now.
> Was not aware but makes perfect sense, to rate limit globally a web farm
with multiple web servers with multiple gunicorn processes you can use
RATELIMIT_STORAGE_URI with redis for example.
> More useful settings can be made for rate limiting based on username, host
etc can be found here:
https://flask-limiter.readthedocs.io/en/stable/configuration.html
> Will Airflow allow admin's to tune these settings also?
I've added more details and documenation on how to configure those. It's
possible - the same way as authentication (via webserver_config.py) - but it
was not "explicitly" stated in the docs (the docs only mentioned that you can
configure authentication options this way, but not any other flask plugin. I
made it explicitly documented and I also added a separate section for "rate
limiting" explaining the (a little unexpected) default behaviour where each
gunicorn process has their own limit and explained how the users could
configure storage to achieve shared limits.
I think that one is ready for final review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
