potiuk commented on code in PR #29927:
URL: https://github.com/apache/airflow/pull/29927#discussion_r1125613733


##########
BREEZE.rst:
##########
@@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use 
``-e`` flag):
 Once this is complete, you should have ``breeze`` binary on your PATH and 
available to run by ``breeze``
 command.
 
+**Docker errors that may come while running breeze**

Review Comment:
   I think it would be better to mention those in the `Prerequisite` section. I 
think we should even add a step of verifying if docker works for you there.
   
   Typically that can be done via `docker run hello-world`. And this is 
happening when all is configured:
   
   ```
   docker run hello-world
   
   Hello from Docker!
   This message shows that your installation appears to be working correctly.
   
   To generate this message, Docker took the following steps:
    1. The Docker client contacted the Docker daemon.
    2. The Docker daemon pulled the "hello-world" image from the Docker Hub.
       (arm64v8)
    3. The Docker daemon created a new container from that image which runs the
       executable that produces the output you are currently reading.
    4. The Docker daemon streamed that output to the Docker client, which sent 
it
       to your terminal.
   
   To try something more ambitious, you can run an Ubuntu container with:
    $ docker run -it ubuntu bash
   
   Share images, automate workflows, and more with a free Docker ID:
    https://hub.docker.com/
   
   For more examples and ideas, visit:
    https://docs.docker.com/get-started/
   ```
   
   BTW. Technically DOCKER_BUILDKIT=1 is not needed. Breeze automaticlaly add 
DOCKER_BUILDKIT=1 whenever it runs any `docker build` command. I wonder where 
you had to add it ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to