hussein-awala commented on code in PR #29809:
URL: https://github.com/apache/airflow/pull/29809#discussion_r1125696401
##########
airflow/kubernetes/kube_client.py:
##########
@@ -105,16 +107,28 @@ def get_kube_client(
if conf.getboolean("kubernetes_executor", "enable_tcp_keepalive"):
_enable_tcp_keepalive()
+ new_client_config = Configuration.get_default_copy()
+ api_client_retry_configuration = conf.getjson("kubernetes",
"api_client_retry_configuration", fallback={})
+
+ if not conf.getboolean("kubernetes_executor", "verify_ssl"):
+ _disable_verify_ssl()
+
+ if isinstance(api_client_retry_configuration, dict) and
api_client_retry_configuration != {}:
+ new_client_config.retries =
urllib3.util.Retry(**api_client_retry_configuration)
+ elif isinstance(api_client_retry_configuration, dict) and
api_client_retry_configuration == {}:
+ pass
Review Comment:
I think no need to check if `api_client_retry_configuration` is empty or
not, where in the two cases it will use the `Retry` default values:
```suggestion
if isinstance(api_client_retry_configuration, dict):
new_client_config.retries =
urllib3.util.Retry(**api_client_retry_configuration)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
