msumit commented on issue #5570: [AIRFLOW-4939] Add default_task_retries config
URL: https://github.com/apache/airflow/pull/5570#issuecomment-511715463
 
 
   Ok, the bug I was hitting in tests was this (from 
[here](https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments))
   `Python’s default arguments are evaluated once when the function is defined, 
not each time the function is called (like it is in say, Ruby). This means that 
if you use a mutable default argument and mutate it, you will and have mutated 
that object for all future calls to the function as well.`
   
   So I've changed the code a bit and now it's much cleaner than before and no 
hacks in tests as well. Please review it again and merge :). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to