PierreC1024 commented on code in PR #29835: URL: https://github.com/apache/airflow/pull/29835#discussion_r1127689746
########## airflow/providers/google/cloud/hooks/bigquery_reservation.py: ########## @@ -0,0 +1,123 @@ +# Review Comment: I have thought about it but it uses the bigquery-reservation API. So, I would prefer keep this name. Moreover, this could be extended with other bigquery-reservation api routes like create and delete bigquery slot reservation (so using the same client). PS: To be honest, It should be my next PR (create and delete BigQuery slots reservation operators) but I wish to validate all the process with BI Engine first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
