vincbeck commented on code in PR #29732:
URL: https://github.com/apache/airflow/pull/29732#discussion_r1128634322


##########
tests/providers/amazon/aws/hooks/test_emr.py:
##########
@@ -191,6 +201,24 @@ def test_get_cluster_id_by_name(self):
 
         assert no_match is None
 
+        with pytest.raises(AirflowException):

Review Comment:
   LGTM but I would move it to a separate test for clarity purposes. The 
shorter the tests are, the more likely people will read them, the better :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to