eladkal commented on code in PR #30032:
URL: https://github.com/apache/airflow/pull/30032#discussion_r1132995115


##########
airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -42,6 +42,7 @@
 import botocore.session
 import requests
 import tenacity
+from aiobotocore.session import AioSession, get_session as async_get_session

Review Comment:
   Having separated base hook for async will not solve the first point you 
mentioned as even if we have 2 hooks eventually they must agree on boto3 
version.
   
   This is one of the cases where the shared governance model of providers is 
helpful. Lets hear AWS folks perspective and if they considered the issues you 
raised.
   
   cc @syedahsn @vincbeck @ferruzzi @o-nikolas  @shubham22
   Please review @Taragolis good points about the release cycle of aiobotocore 
and the effect it will have on limiting boto3 version for long period of time



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to