ephraimbuddy commented on code in PR #30030:
URL: https://github.com/apache/airflow/pull/30030#discussion_r1133051598
##########
dev/breeze/src/airflow_breeze/commands/release_candidate_command.py:
##########
@@ -190,16 +190,16 @@ def prepare_pypi_packages(version, version_suffix,
repo_root):
console_print("PyPI packages prepared")
-def push_packages_to_test_pypi():
+def push_packages_to_test_pypi(version):
if confirm_action("Do you want to push packages to test PyPI?"):
run_command(["twine", "upload", "-r", "pypitest", "dist/*"],
dry_run_override=DRY_RUN, check=True)
console_print("Packages pushed to test PyPI")
console_print(
"Verify that the test package looks good by downloading it and
installing it into a virtual "
"environment. The package download link is available at: "
- "https://test.pypi.org/project/apache-airflow/#files";
- "Install it with the appropriate constraint file, for instance: "
- "pip install <download_link> --constraint
https://raw.githubusercontent.com/apache/airflow/constraints-2.2.1rc1/constraints-3.8.txt";
# noqa: 501
+ "https://test.pypi.org/project/apache-airflow/#files "
+ "Install it with the appropriate constraint file, adapt python
version: "
+ f"pip install https://test.pypi.org/simple/
apache-airflow=={version} --constraint
https://raw.githubusercontent.com/apache/airflow/constraints-{version}/constraints-3.8.txt";
# noqa: 501
Review Comment:
I still got errors:
```
(env) ➜ airflow pip install -i https://test.pypi.org/simple/
apache-airflow==2.5.2rc1 --constraint
https://raw.githubusercontent.com/apache/airflow/constraints-2.5.2rc1/constraints-3.9.txt
Looking in indexes: https://test.pypi.org/simple/
Collecting apache-airflow==2.5.2rc1
Using cached
https://test-files.pythonhosted.org/packages/d7/e6/2032cc1e9409f1b332ffe6831a9fb90d3d62c86a4d3add35b81baa4a341c/apache_airflow-2.5.2rc1-py3-none-any.whl
(11.6 MB)
ERROR: Cannot install apache-airflow==2.5.2rc1 because these package
versions have conflicting dependencies.
The conflict is caused by:
apache-airflow 2.5.2rc1 depends on rfc3339-validator>=0.1.4
The user requested (constraint) rfc3339-validator==0.1.4
To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency
conflict
ERROR: ResolutionImpossible: for help visit
https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
