potiuk commented on PR #30068:
URL: https://github.com/apache/airflow/pull/30068#issuecomment-1465974310
You need to fix the static checks. However, when I looked at it - maybe you
might want to make a better and more future-proof fix ?
It should be possible to make the check only for `extra` and still allow the
Operator's `spark_binary` to be anything. Currently we check it in `__init__`
of the hook - but if we check it where `extra.get("spark-binary",
"spark-submit")` is called (extracting that to a method) - then we could allow
any spark_binary to be passed as operator's parameter.
The security issue was only about the "extra" (because it could be changed
via the UI when defining connection) - but there is no problem with passing any
binary via Operator in the DAG code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
