uranusjr commented on PR #29721: URL: https://github.com/apache/airflow/pull/29721#issuecomment-1466145151
I have to disagree on the maintenance part. While separating individual (de)serialiser declarations should reduce mental overhead, the requirement for it—keeping expensive imports local instead of module-level—creates at least equal, if not more mental overhead. As an example, we profiled the secret masking module when it’s first introduced (because the module is loaded when logging is configured and needs to be reasonably performant), but a slowdown very easily slipped through maintainer reviews when a contribution was made. Personally I feel it is much more easier to keep a central registry in sync since it would be more obvious for reviewers when new serialisers are added via a pull request than a seemingly innocent module-level import. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
