JDarDagran commented on code in PR #29940: URL: https://github.com/apache/airflow/pull/29940#discussion_r1134072255
########## airflow/providers/openlineage/extractors/extractors.py: ########## @@ -0,0 +1,65 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import os + +from airflow.providers.openlineage.extractors.base import BaseExtractor, DefaultExtractor + + +class Extractors: + """ + This exposes implemented extractors, while hiding ones that require additional, unmet + dependency. Patchers are a category of extractor that needs to hook up to operator's + internals during DAG creation. + """ + + def __init__(self): + # Do not expose extractors relying on external dependencies that are not installed + self.extractors = {} + self.default_extractor = DefaultExtractor + + # Comma-separated extractors in OPENLINEAGE_EXTRACTORS variable. + # Extractors should implement BaseExtractor + from airflow.providers.openlineage.utils import import_from_string + + env_extractors = os.getenv("OPENLINEAGE_EXTRACTORS") + if env_extractors is not None: + for extractor in env_extractors.split(";"): Review Comment: `;` was supported in `openlineage-airflow`. I think we want to maintain suppot fo custom extractors as it was for a while. Eventually, we could split on `;` or `,`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
