bolkedebruin commented on PR #29721: URL: https://github.com/apache/airflow/pull/29721#issuecomment-1467607698
Well, I think the fact that you have encountered the issue yourself proves otherwise? The issue is that currently you can now drop a new (de)serializer in the namespace (as an administrator). The serializers would then register themselves.With your change you cannot do that anymore and you made it static and thus require core changes when adding a (de)serializer. The plugin system was intentional and I do not think it makes sense to remove it. If we are so afraid of hitting a performance bottleneck due to oversight during review we could `timeit` during CI/CD with a flamegraph to make it fancy or do AST parsing instead of module loading. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
