bbovenzi commented on code in PR #30100:
URL: https://github.com/apache/airflow/pull/30100#discussion_r1135591285
##########
airflow/www/static/js/dag/details/graph/utils.ts:
##########
@@ -109,16 +117,17 @@ export const flattenNodes = ({
};
export const nodeColor = ({
- data: { height, width, instance },
+ data: { height, width, instance, childCount, isActive },
}: ReactFlowNode<CustomNodeProps>) => {
+ let opacity = "90";
+ let color = "#cccccc";
if (!height || !width) return "";
- if (width > 200 || height > 60) {
- return "#cccccc50";
- }
- if (instance?.state) {
- return `${Color(stateColors[instance.state]).hex()}90`;
- }
- return "#cccccc90";
+ if (instance?.state && !childCount)
Review Comment:
Also, figured that checking the child count is better than checking the node
size to determine if the node is a group in the minimap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
