hussein-awala opened a new pull request, #30110:
URL: https://github.com/apache/airflow/pull/30110

   closes: #30097
   
   ---
   The triggerer job [logs the trigger 
name](https://github.com/apache/airflow/blob/main/airflow/jobs/triggerer_job.py#L592-L593),
 which is 
[repr(trigger_instance)](https://github.com/apache/airflow/blob/main/airflow/jobs/triggerer_job.py#L488),
 so it logs all the fields in the `trigger_instance` even if they contain 
sensitive. We have some different options to fix this:
   - use 
[redact](https://github.com/apache/airflow/blob/main/airflow/utils/log/secrets_masker.py#L111-L111)
 in `__repr__` method -> difficult to detect all the sensitive information
   - add a new attribute to hide some fields -> it can work, but we need to 
identify all the sensitive fields in each new trigger
   - simply change the trigger name -> IMHO it's the best solution, also the 
trigger name should be significant and related to the task instance
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to