ashb commented on code in PR #30118:
URL: https://github.com/apache/airflow/pull/30118#discussion_r1136910168
##########
airflow/providers/docker/decorators/docker.py:
##########
@@ -79,10 +79,6 @@ class _DockerDecoratedOperator(DecoratedOperator,
DockerOperator):
template_fields: Sequence[str] = (*DockerOperator.template_fields,
"op_args", "op_kwargs")
- # since we won't mutate the arguments, we should just do the shallow copy
- # there are some cases we can't deepcopy the objects (e.g protobuf).
- shallow_copy_attrs: Sequence[str] = ("python_callable",)
Review Comment:
I double checked, and this was introduced in 2.1 with
https://github.com/apache/airflow/pull/14709 so there's no version issues we
have to worry about here.
##########
airflow/providers/docker/decorators/docker.py:
##########
@@ -79,10 +79,6 @@ class _DockerDecoratedOperator(DecoratedOperator,
DockerOperator):
template_fields: Sequence[str] = (*DockerOperator.template_fields,
"op_args", "op_kwargs")
- # since we won't mutate the arguments, we should just do the shallow copy
- # there are some cases we can't deepcopy the objects (e.g protobuf).
- shallow_copy_attrs: Sequence[str] = ("python_callable",)
Review Comment:
I double checked, and this was introduced on DecoratedOperator in 2.1 with
https://github.com/apache/airflow/pull/14709 so there's no version issues we
have to worry about here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
