potiuk commented on code in PR #30076:
URL: https://github.com/apache/airflow/pull/30076#discussion_r1137871955
##########
airflow/dag_processing/manager.py:
##########
@@ -727,7 +740,8 @@ def _add_callback_to_queue(self, request: CallbackRequest):
self._file_path_queue = collections.deque(
file_path for file_path in self._file_path_queue if
file_path != request.full_filepath
)
- self._file_path_queue.appendleft(request.full_filepath)
+ self._add_paths_to_queue([request.full_filepath], True)
+ Stats.incr("dag_processing.other_callback_count")
Review Comment:
Can you please add description of those metrics to
https://airflow.apache.org/docs/apache-airflow/stable/administration-and-deployment/logging-monitoring/metrics.html#metrics
##########
airflow/dag_processing/manager.py:
##########
@@ -727,7 +740,8 @@ def _add_callback_to_queue(self, request: CallbackRequest):
self._file_path_queue = collections.deque(
file_path for file_path in self._file_path_queue if
file_path != request.full_filepath
)
- self._file_path_queue.appendleft(request.full_filepath)
+ self._add_paths_to_queue([request.full_filepath], True)
+ Stats.incr("dag_processing.other_callback_count")
Review Comment:
Can you please add description of those added metrics to
https://airflow.apache.org/docs/apache-airflow/stable/administration-and-deployment/logging-monitoring/metrics.html#metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
