SamWheating commented on code in PR #29909:
URL: https://github.com/apache/airflow/pull/29909#discussion_r1138094579
##########
airflow/models/dag.py:
##########
@@ -546,6 +553,9 @@ def __init__(
self.last_loaded = timezone.utcnow()
self.safe_dag_id = dag_id.replace(".", "__dot__")
self.max_active_runs = max_active_runs
+ if self.timetable.limit_active_runs is not None:
+ if self.timetable.limit_active_runs < self.max_active_runs:
+ self.max_active_runs = self.timetable.limit_active_runs
Review Comment:
I'm fine with an error - that way we won't have any confusing mismatch
between the code and the actual behaviour of a running DAG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
