jedcunningham commented on code in PR #30130:
URL: https://github.com/apache/airflow/pull/30130#discussion_r1138750108
##########
airflow/www/views.py:
##########
@@ -297,7 +297,7 @@ def dag_to_grid(dag: DagModel, dag_runs: Sequence[DagRun],
session: Session):
grouped_tis = {task_id: list(tis) for task_id, tis in
itertools.groupby(query, key=lambda ti: ti.task_id)}
def task_group_to_grid(item, grouped_tis, *, is_parent_mapped: bool):
- if isinstance(item, AbstractOperator):
+ if not isinstance(item, TaskGroup):
Review Comment:
This seems okay to me.
##########
airflow/www/static/js/dag/InstanceTooltip.test.tsx:
##########
@@ -40,12 +40,18 @@ describe("Test Task InstanceTooltip", () => {
test("Displays a normal task", () => {
const { getByText, queryByText } = render(
<InstanceTooltip
- group={{ id: "task", label: "task", instances: [] }}
+ group={{
+ id: "task",
+ label: "task",
+ instances: [],
+ triggerRule: "all_failed",
+ }}
Review Comment:
This feels wrong. A "group" doesn't have a trigger rule. Should this be
"node" or "item", not "group"? Definitely a problem for another PR, but we
should probably rename this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
