potiuk commented on PR #30152: URL: https://github.com/apache/airflow/pull/30152#issuecomment-1473159913
> the other thing is it's technically breaking. i.e. if anyoen has implemented this method. but maybe you call it a bugfix. i don't have a strong opinion. i suppose you might be able to inspect it. Technically speaking it's not breaking. I thought about it - but if you wrote a regular method that would not use "sync" call, things will work as usual. But if you did use a "sync" call (say HTTP request) you would get the warnings that are mentioned in the linked discussion - and technically your implementation was wrong, because it was breaking the promise of the async main loop processing. So I would at most add a "significant" entry mentioning this change and treat it as "bugfix". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
