jedcunningham commented on code in PR #29818:
URL: https://github.com/apache/airflow/pull/29818#discussion_r1140520464
##########
chart/values.yaml:
##########
@@ -1822,6 +1822,8 @@ config:
ccache: '{{ .Values.kerberos.ccacheMountPath }}/{{
.Values.kerberos.ccacheFileName }}'
celery_kubernetes_executor:
kubernetes_queue: 'kubernetes'
+ # The `kubernetes` section is deprecated in Airflow >= 2.5.0 due to a
airflow.cfg scheme change.
+ # The `kubernetes` section can be removed once the helm chart no longer
supports Airflow < 2.5.0.
kubernetes:
namespace: '{{ .Release.Namespace }}'
airflow_configmap: '{{ include "airflow_config" . }}'
Review Comment:
```suggestion
# The following `airflow_` entries are for Airflow 1, and can be removed
when it is no longer supported.
airflow_configmap: '{{ include "airflow_config" . }}'
```
Let's add a note about these as well.
##########
chart/values.yaml:
##########
@@ -1822,6 +1822,8 @@ config:
ccache: '{{ .Values.kerberos.ccacheMountPath }}/{{
.Values.kerberos.ccacheFileName }}'
celery_kubernetes_executor:
kubernetes_queue: 'kubernetes'
+ # The `kubernetes` section is deprecated in Airflow >= 2.5.0 due to a
airflow.cfg scheme change.
Review Comment:
```suggestion
# The `kubernetes` section is deprecated in Airflow >= 2.5.0 due to an
airflow.cfg scheme change.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
