dylanbstorey commented on code in PR #30175: URL: https://github.com/apache/airflow/pull/30175#discussion_r1140899765
########## airflow/providers/apache/kafka/hooks/producer.py: ########## @@ -0,0 +1,55 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from typing import Any + +from confluent_kafka import Producer + +from airflow.exceptions import AirflowException +from airflow.hooks.base import BaseHook + + +class KafkaProducerHook(BaseHook): + """KafkaProducerHook + + A hook for creating a Kafka Producer + :param config: A config dictionary to use with confluent_kafka library, defaults to None + """ + + def __init__( + self, + config: dict[Any, Any] | None = None, + no_broker: bool = False, + ) -> None: + super().__init__() + + self.config: dict[Any, Any] = config or {} + + if not self.config.get("bootstrap.servers", None): Review Comment: From the original provider package > Why is most of the configuration handled in a dict ? Because that's how confluent-kafka does it. I'd rather maintain interfaces that people already using kafka are comfortable with as a starting point - I'm happy to add more options/ interfaces in later but would prefer to be thoughtful about it to ensure that there difference between these operators and the actual client interface are minimal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
